London | May-2025| Anuar Duisenbek | Module-Data -Groups | Sprint-2 #705
Conversation
AnuarBey
added
the
Needs Review
Sprint-2/implement/querystring.js
Outdated
There was a problem hiding this comment.
Good job!
In the real world, URLs are usually encoded with percent encoding to represent special characters. In URL, & can be used as a separator (key=value&key=value...) or special character within a key or value. if we were to use & as a special character, we need to encode it.
Can you refactor the code so that parseQueryString("a%25b=c%26d") results in { "a%b": "c&d" }?
FYI, %25 is same as %, %26 is same as &
There was a problem hiding this comment.
Ok,done!
I did't know about it before.
Sprint-2/implement/tally.js
Outdated
| for (const item of arr) { | ||
| if (obj[item]) { | ||
| obj[item]++; | ||
| } else { | ||
| obj[item] = 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Well done. As a challenge, would you like to refactor the code to use forEach array method?
Sprint-2/interpret/invert.js
Outdated
|
|
||
| // c) What does Object.entries return? Why is it needed in this program? | ||
| // it return key and value inverted; |
There was a problem hiding this comment.
That's not quite right. Can you answer this question again?
There was a problem hiding this comment.
@day-lee Yes, i changed my comment there.
There was a problem hiding this comment.
Object.entries() convert an object into an array of key-value pairs hence you can use for...of loops.
day-lee
added
Reviewed
AnuarBey
added
Needs Review
day-lee
added
Reviewed
AnuarBey
removed
the
Reviewed
Learners, PR Template
Self checklist
Changelist
Feat: implement and test solutions for sprint-2
Questions
Ask any questions you have for your reviewer.